docs: update solar angle definitions in nomenclature #2482
Closed
+196
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add detailed definitions for solar angles with range constraints - Clarify pvlib's east-of-north convention for azimuth angles - Add cross-references between related terms using :term: directive - Add coordinate system conventions for latitude/longitude - Enhance existing angle definitions with usage notes and examples This commit addresses issue pvlib#2448 by migrating angle definitions and conventions from parameter descriptions to the nomenclature page.
- Introduced a new function to infer updated coefficients for the Huld model based on EU JRC research. - Added a parameter to the existing Huld function to optionally use these updated coefficients. - Updated documentation to reflect the new functionality and included references to the EU JRC paper. - Added tests to verify the implementation and ensure compatibility with existing functionality.
- Updated the test for the Huld model to use non-reference values for irradiance and temperature. - Enhanced the test to verify that results differ for all supported cell types when using EU JRC coefficients. - Added checks to ensure all cell types are supported and that a KeyError is raised for invalid cell types.
- Created test_solar_angles.py to verify solar angle calculations - Tests zenith, azimuth, and elevation angles for different times of day - Uses New York City as example location on spring equinox - Verifies angles are within expected ranges and follow correct patterns
…s/test_solarposition.py - Deleted the standalone test_solar_angles.py file. - Added a new test function, test_solar_angles_spring_equinox, to tests/test_solarposition.py. - The new test verifies solar angles for New York City on the spring equinox, ensuring angles are within expected ranges and follow correct patterns.
|
@OmarBahamida could you separate these changes into two pull requests? One for the nomenclature, and the other for the Huld coefficients. It's much easier to review in smaller parts. |
|
@OmarBahamida if this PR is superceded by the others, please close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #2448 by migrating angle definitions and conventions from parameter descriptions to the nomenclature page.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.