Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parseInt and toString instead of lookup tables #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use parseInt and toString instead of lookup tables #155

wants to merge 2 commits into from

Conversation

timhuff
Copy link

@timhuff timhuff commented Oct 17, 2021

No description provided.

@pwlmaciejewski pwlmaciejewski self-requested a review November 1, 2021 16:15
pwlmaciejewski
pwlmaciejewski requested changes Nov 1, 2021
View reviewed changes
index.js Outdated
ret += lookup[s[i]];
}
return ret;
return s.split('').map(hexDigit => parseInt(hexDigit, 16).toString(2)).join('')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timhuff please fix the failing build

@stale
Copy link

stale bot commented Oct 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 30, 2022
@Eghizio
Copy link

Eghizio commented Nov 4, 2022

This hexToBinary change breaks the tests

@stale stale bot removed the wontfix label Nov 4, 2022
@Eghizio Eghizio mentioned this pull request Nov 5, 2022
Open
@timhuff
Copy link
Author

timhuff commented Nov 6, 2022

@pwlmaciejewski @Eghizio Pardon the delay on this. I'll get this fixed in a jiffy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwlmaciejewski pwlmaciejewski pwlmaciejewski requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timhuff @Eghizio @pwlmaciejewski