-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft pr1 #325
Draft
1andrin
wants to merge
15
commits into
py-why:main
Choose a base branch
from
1andrin:draft_pr1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Draft pr1 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1andrin <[email protected]>
…d some files from experiments Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
…w score bite Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Signed-off-by: 1andrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Increase number of available scores, fix issues in existing scores, extend functionality of datasets.py to include generation of data with known propensites, simplify the running of experiments. Facilitate reproducible experiments.
Proposed changes
Extended scoring.py with the new BITE metrics, updated the forbenius norm score, updated policy risk, updated probabilistic erupt. Added a method to create data with known propensities in datasets.py. Created the experiment_runner.py file to facilitate simplified experiment runs and added instructional readme. Added a set of pre-made data sets for each scenario to allow for reproducible experiments.
Types of changes
What types of changes does your code introduce to causaltune?
Put an
x
in the boxes that applyChecklist
setup.py
is an individual PR and not mixed with feature or bugfix PRs