fix: Set SliderProxy range params to Any #290
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the types are ints, this raises mypy errors when e.g. setting the range of a QDoubleSlider to float values. This change aligns with the parameter typing of _SliderProxy.setValue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 87.01% 87.12% +0.10%
==========================================
Files 49 49
Lines 3774 3774
==========================================
+ Hits 3284 3288 +4
+ Misses 490 486 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would float satisfy mypy? (I think it works for int too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the types are
ints, this raises mypy errors when e.g. setting the range of aQDoubleSliderto float values.This change aligns with the parameter typing of
_SliderProxy.setValue