Add holder caster traits tests in test_smart_ptr.cpp,py #5603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with clang-tidy locally.
rwgk
changed the title
henryiii
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for these holder caster traits:
copyable_holder_caster_shared_ptr_with_smart_holder_support_enabledmove_only_holder_caster_unique_ptr_with_smart_holder_support_enabledTo be documented in the pybind11 v3.0 Upgrade guide (PR #5589).
While at it, add a matching "to demonstrate" provision to the existing
type_caster_enum_type_enabledtrait test.A changelog entry is not needed.