raise ValueError when loading a too small modulus DH private key #13269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
dh-nonsense
branch
4 times, most recently
from
0e67073 to
68fd1a6
Compare
reaperhulk
reviewed
Aug 8, 2025
| @@ -1355,6 +1355,15 @@ def test_pem_encryption_short_iv(self): | |||
| with pytest.raises(ValueError): | |||
| load_pem_private_key(data, password=b"password") | |||
|
|
|||
| def test_dh_key_too_small_modulus_raises_value_error(self): | |||
There was a problem hiding this comment.
What does this test do that the revised test_load_256bit_key_from_pkcs8 does not?
reaperhulk
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13050