Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from the upstream template #47

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 6, 2024

Types of changes

  • Other (please describe)

Description

Update from the upstream template https://github.com/Lee-W/cookiecutter-python-template

  • update minimum Python version to 3.8
  • replace pylint, flake8 with ruff
  • use github issue template with web form support
  • run pre-commit hooks in CI to ensure consistence development experiment

Checklist:

  • Add test cases to all the changes you introduce
  • Run inv style locally to ensure all linter checks pass
  • Run inv test locally to ensure all test cases pass
  • Run inv secure locally to ensure no major vulnerability is introduced
  • Update the documentation if necessary

Steps to Test This Pull Request

Expected behavior

no functionality change

Related Issue

Additional context

@Lee-W Lee-W requested a review from andylee830914 April 6, 2024 12:09
@Lee-W Lee-W force-pushed the update-from-the-upstream-template branch from a1fac86 to 68af0a2 Compare April 6, 2024 12:16
.cruft.json Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/documentation.yaml Outdated Show resolved Hide resolved
.github/workflows/cruft-update.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
.github/workflows/master-updated.yaml Show resolved Hide resolved
.github/workflows/master-updated.yaml Outdated Show resolved Hide resolved
@Xiao75896453
Copy link

I currently use pylint and flake8. It seems that ruff is more powerful tool 🤩

.github/workflows/master-updated.yaml Show resolved Hide resolved
tasks/env.py Show resolved Hide resolved
@Lee-W Lee-W merged commit 03563b8 into master Jun 6, 2024
15 checks passed
@Lee-W Lee-W deleted the update-from-the-upstream-template branch June 6, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants