-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KKTIX Backfill #109
base: master
Are you sure you want to change the base?
KKTIX Backfill #109
Conversation
@@ -127,6 +127,7 @@ Please use Gitlab Flow, otherwise you cannot pass dockerhub CI | |||
* KLAVIYO_LIST_ID: Create from https://www.klaviyo.com/lists | |||
* KLAVIYO_CAMPAIGN_ID: Create from https://www.klaviyo.com/campaigns | |||
* kktix_events_endpoint: url path of kktix's `hosting_events`, ask @gtb for details! | |||
* kktix_only_not_ended_events: decide whether to only retrieve ended events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to clarify, this DAG is only for backfill, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, only for backfill :)
TABLE = f"{os.getenv('BIGQUERY_PROJECT')}.ods.ods_kktix_attendeeId_datetime" | ||
TABLE = f"{os.getenv('BIGQUERY_PROJECT')}.ods.ods_kktix_attendeeId_datetime_copy2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy2 is only testing right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Types of changes
Description
start_date
set to the end of 2011, allowing airflow request data since 2012.schedule_interval
set to@yearly
so it will request data on a yearly basis.Checklist:
poetry run pytest
locally to ensure all linter checks passSteps to Test This Pull Request
Expected behavior
Related Issue
Additional context