Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KKTIX Backfill #109

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

KKTIX Backfill #109

wants to merge 3 commits into from

Conversation

tomatoprinx
Copy link
Collaborator

@tomatoprinx tomatoprinx commented Mar 4, 2023

Types of changes

  • New feature
  • Refactoring
  • Documentation Update

Description

  • Applied kktix api in DAG.
  • start_date set to the end of 2011, allowing airflow request data since 2012.
  • schedule_interval set to @yearly so it will request data on a yearly basis.

Checklist:

  • Add test cases to all the changes you introduce
  • Run poetry run pytest locally to ensure all linter checks pass
  • Update the documentation if necessary

Steps to Test This Pull Request

Expected behavior

Related Issue

Additional context

@tomatoprinx tomatoprinx requested a review from david30907d March 4, 2023 08:43
@@ -127,6 +127,7 @@ Please use Gitlab Flow, otherwise you cannot pass dockerhub CI
* KLAVIYO_LIST_ID: Create from https://www.klaviyo.com/lists
* KLAVIYO_CAMPAIGN_ID: Create from https://www.klaviyo.com/campaigns
* kktix_events_endpoint: url path of kktix's `hosting_events`, ask @gtb for details!
* kktix_only_not_ended_events: decide whether to only retrieve ended events
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to clarify, this DAG is only for backfill, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, only for backfill :)

TABLE = f"{os.getenv('BIGQUERY_PROJECT')}.ods.ods_kktix_attendeeId_datetime"
TABLE = f"{os.getenv('BIGQUERY_PROJECT')}.ods.ods_kktix_attendeeId_datetime_copy2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy2 is only testing right?

Copy link
Collaborator

@david30907d david30907d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants