Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static): proposal system bg img is not shown when local dev #1181

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mattwang44
Copy link
Member

Types of changes

  • Bugfix

Description

The background image is not shown when dev with the local server (but appears on staging/production).

Steps to Test This Pull Request

  1. run local server
  2. bg image not shown and has error messages

Expected behavior

no error msg and the background image has displayed

@mattwang44 mattwang44 requested a review from SivanYeh April 13, 2024 11:05
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.00%. Comparing base (e4af425) to head (d22ec94).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1181   +/-   ##
=======================================
  Coverage   71.00%   71.00%           
=======================================
  Files          85       85           
  Lines        3445     3445           
=======================================
  Hits         2446     2446           
  Misses        999      999           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattwang44 mattwang44 requested a review from josix April 16, 2024 05:14
Copy link
Collaborator

@SivanYeh SivanYeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
image

@SivanYeh SivanYeh merged commit 8516ede into master Apr 16, 2024
3 checks passed
@mattwang44 mattwang44 deleted the fix-proposal-system-bg-img branch April 16, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants