Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] improve containerized dev env - makefile and compose file #1198

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

changchaishi
Copy link
Contributor

Types of changes

Feature

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

Describe what the change is

  • Remove enter_dev_env.sh, I think we could deprecate it as it was using the old compose cli scheme
  • Remove docker-compose-db.yml, I think it is extra as we can simply use the compose command to spin up a service using the service name, and we can merge the db and pycontw service into 1 compose file
  • For the first time to up the compose for dev, Django needs to wait for db to be ready, so I added psql client to the docker file
  • db can share between local development and containerized dev development
  • makefile has an init command to help local development spin up the project, other commands need to refer to docs instead
  • update docs accordingly

@changchaishi changchaishi requested a review from mattwang44 June 7, 2024 09:01
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.99%. Comparing base (0fa2454) to head (08915ad).
Report is 24 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1198   +/-   ##
=======================================
  Coverage   73.99%   73.99%           
=======================================
  Files          81       81           
  Lines        3057     3057           
=======================================
  Hits         2262     2262           
  Misses        795      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docker-compose-dev.yml Outdated Show resolved Hide resolved
document/deploy_docker_dev.md Show resolved Hide resolved
document/deploy_docker_dev.md Show resolved Hide resolved
@changchaishi
Copy link
Contributor Author

Hi @mattwang44 , 已修正修正上述問題。再麻煩 review 一下。謝謝。

Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Table review LGTM, I'll get back to this to try out the script when I'm available, thx!

@changchaishi changchaishi requested a review from mattwang44 June 29, 2024 08:41
@SivanYeh
Copy link
Collaborator

SivanYeh commented Jul 2, 2024

I tried "deploy_docker_dev" on my local and it worked well~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants