-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] improve containerized dev env - makefile and compose file #1198
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
=======================================
Coverage 73.99% 73.99%
=======================================
Files 81 81
Lines 3057 3057
=======================================
Hits 2262 2262
Misses 795 795 ☔ View full report in Codecov by Sentry. |
replace script with healthcheck
Hi @mattwang44 , 已修正修正上述問題。再麻煩 review 一下。謝謝。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Table review LGTM, I'll get back to this to try out the script when I'm available, thx!
I tried "deploy_docker_dev" on my local and it worked well~ |
Types of changes
Feature
Description
Describe what the change is
enter_dev_env.sh
, I think we could deprecate it as it was using the old compose cli schemedocker-compose-db.yml
, I think it is extra as we can simply use the compose command to spin up a service using the service name, and we can merge the db and pycontw service into 1 compose file