fix: docker dev error, json-server version specify #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for ephemeral-sable-89c7e0 pending review.Visit the deploys page to approve it
|
rockleona
force-pushed
the
fix/docker-dev-error
branch
from
912505e to
c5f855c
Compare
已經修改了， 我想應該只有 node 版本需要更新？ |
mattwang44
approved these changes
Feb 15, 2024
|
這邊不上到 node 18 or 20 是因為有套件相依性的關係嗎？ #423 似乎在做一樣的事情 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Due to
json-serverhad release a new version1.0.0-alpha.23,it must use node18 or higher, since
mock-server.Dockerfiledid not copypackage-lock.json,so I've edited the line to download the specific version of
json-serverSteps to Test This Pull Request
Steps to reproduce the behavior:
docker-compose -f ./docker-compose-dev.yml upExpected behavior
mock-serverandpycontw-2024-frontend-devare runningwindow is not defined, it is fined, PR fix: leafleat module import error in ssr mode #474 will fix the errorRelated Issue
Related to #471 and #474