Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reg/tickets): update content to 2024 in ticket page #535

Merged
merged 5 commits into from
Jun 9, 2024

Conversation

SivanYeh
Copy link
Collaborator

@SivanYeh SivanYeh commented Jun 4, 2024

Types of changes

  • New feature

Description

Release 2024 Ticket Info

Steps to Test This Pull Request

  1. Go to “http://localhost:3000/2024/zh-hant/registration/tickets"
  2. Check if content has been updated and matched the document: https://docs.google.com/document/d/1fqyk_UEdX1k44xjHzUGevWDQ8PgsIQ9_T32DmTQ_bRw/edit.
  3. Repeat step 1-2 for english version “http://localhost:3000/2024/en-us/registration/tickets”

Related Issue

#523

Screenshot

image

image

SivanYeh added 2 commits June 3, 2024 15:28
- Unhide "ticket_info" page of registration in navigation bar.
- Update the content on the page to the 2024 version.
Add list-disc to sublist items.
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit 130a1c3
🔍 Latest deploy log https://app.netlify.com/sites/classy-granita-bc2b5a/deploys/66650f39316a0a0008811d03
😎 Deploy Preview https://deploy-preview-535--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit 130a1c3
🔍 Latest deploy log https://app.netlify.com/sites/zesty-gnome-f04144/deploys/66650f39ae37020008e445a4
😎 Deploy Preview https://deploy-preview-535--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Remove redundancy and fix typo.
@SivanYeh SivanYeh marked this pull request as ready for review June 5, 2024 09:57
@SivanYeh SivanYeh changed the title Feat(reg/tickets): update content to 2024 in ticket page feat(reg/tickets): update content to 2024 in ticket page Jun 5, 2024
Copy link
Contributor

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review 1st Round!

configs/pageTickets.js Show resolved Hide resolved
configs/pageTickets.js Outdated Show resolved Hide resolved
Fix typo of year and price
@SivanYeh
Copy link
Collaborator Author

SivanYeh commented Jun 6, 2024

@rockleona fixed! 感謝挑錯!!

@SivanYeh SivanYeh requested a review from rockleona June 6, 2024 13:40
Copy link
Contributor

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 可能要提醒下一個階段處理這個頁面的志工留意一下有關 KKTIX 的連結

@SivanYeh SivanYeh merged commit a2791a0 into main Jun 9, 2024
9 checks passed
@SivanYeh SivanYeh deleted the feat/update-content-in-ticket-page branch June 9, 2024 02:14
@SivanYeh SivanYeh restored the feat/update-content-in-ticket-page branch June 9, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants