Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(about/coc): Convert PNG to SVG and Adjust CSS #563

Merged
merged 3 commits into from
Aug 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/core/layout/TwoColWrapper.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default {

<style lang="postcss" scpoed>
.two-col-layout {
@media (min-width: 1024px) {
@media (min-width: 1194px) {
grid-template-columns: 1fr 5fr;
}
}
Expand Down
25 changes: 10 additions & 15 deletions pages/about/code-of-conduct.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div class="py-10 md:pb-24 lg:pb-24">
<banner>
<banner class="bg-center bg-no-repeat">
<core-h1 :title="$t('title')"></core-h1>
<p class="leading-6">
{{ $t('pageAbstract') }}
Expand All @@ -9,7 +9,7 @@
<div class="mx-2 my-3 flex flex-wrap justify-center">
<div v-for="(img, i) in introImgs" :key="`intro_img_${i}`">
<div
class="mx-2 my-3 h-24 w-32 bg-contain bg-no-repeat md:mx-5 md:h-40 md:w-56"
class="mx-2 my-3 h-24 w-32 rounded-lg bg-contain bg-cover bg-no-repeat md:mx-5 md:h-40 md:w-56"
:style="getImgStyle(img)"
></div>
</div>
Expand Down Expand Up @@ -176,13 +176,13 @@ import ExtLink from '@/components/core/links/ExtLink.vue'
import IntroImg1 from '@/static/img/about/code-of-conduct/Intro-1.png'
import IntroImg2 from '@/static/img/about/code-of-conduct/Intro-2.png'
import IntroImg3 from '@/static/img/about/code-of-conduct/Intro-3.png'
import Icon1 from '@/static/img/about/code-of-conduct/Icon-1.png'
import Icon2 from '@/static/img/about/code-of-conduct/Icon-2.png'
import Icon3 from '@/static/img/about/code-of-conduct/Icon-3.png'
import ProcedureZh from '@/static/img/about/code-of-conduct/procedure-zh.png'
import ProcedureZhRwd from '@/static/img/about/code-of-conduct/procedure-zh-rwd.png'
import ProcedureEn from '@/static/img/about/code-of-conduct/procedure-en.png'
import ProcedureEnRwd from '@/static/img/about/code-of-conduct/procedure-en-rwd.png'
import Icon1 from '@/static/img/about/code-of-conduct/Icon-1.svg'
import Icon2 from '@/static/img/about/code-of-conduct/Icon-2.svg'
import Icon3 from '@/static/img/about/code-of-conduct/Icon-3.svg'
import ProcedureZh from '@/static/img/about/code-of-conduct/procedure-zh.svg'
import ProcedureZhRwd from '@/static/img/about/code-of-conduct/procedure-zh-rwd.svg'
import ProcedureEn from '@/static/img/about/code-of-conduct/procedure-en.svg'
import ProcedureEnRwd from '@/static/img/about/code-of-conduct/procedure-en-rwd.svg'
import TwoColWrapper from '@/components/core/layout/TwoColWrapper'

export default {
Expand All @@ -209,8 +209,6 @@ export default {
bannerStyle() {
return {
'background-image': `url(${this.aboutBanner})`,
'background-repeat': 'no-repeat',
'background-position': 'center',
}
},
sub2Imgs() {
Expand All @@ -225,8 +223,6 @@ export default {
getImgStyle(img) {
return {
'background-image': `url(${img})`,
'border-radius': '5%',
'background-size': 'cover',
}
},
getSub1Style(img) {
Expand All @@ -237,7 +233,6 @@ export default {
getSub2Style(img) {
return {
'background-image': `url(${img})`,
'background-position': 'center',
}
},
},
Expand Down Expand Up @@ -298,7 +293,7 @@ export default {
}

.sub2_img {
@apply mx-2 my-2 hidden bg-no-repeat md:mx-5;
@apply mx-2 my-2 hidden bg-center bg-no-repeat md:mx-5;
width: 30rem;
height: 40rem;
}
Expand Down
13 changes: 13 additions & 0 deletions static/img/about/code-of-conduct/Icon-1.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions static/img/about/code-of-conduct/Icon-2.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions static/img/about/code-of-conduct/Icon-3.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading