Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormField): accept className #163

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rgimen3z
Copy link
Contributor

Would be useful to be able to specify classes for FormFields

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (398147e) 95.68% compared to head (ed8f947) 95.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          14       14           
  Lines         950      950           
=======================================
  Hits          909      909           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add a test.

@rgimen3z
Copy link
Contributor Author

Looks good, but please add a test.

added here: ed8f947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants