Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS Bedrock Converse API #994

Merged
merged 29 commits into from
Mar 7, 2025
Merged

Add support for AWS Bedrock Converse API #994

merged 29 commits into from
Mar 7, 2025

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Feb 26, 2025

This PR started as a copy of the repository pydantic-ai-bedrock.

I have consent from the author to copy, according to this message, cc @Wh1isper

Copy link

github-actions bot commented Feb 26, 2025

Docs Preview

commit: a9d7163
Preview URL: https://8faef4a3-pydantic-ai-previews.pydantic.workers.dev

Copy link
Contributor

@Wh1isper Wh1isper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m happy to see this PR and the progress the pydantic-ai team has made. Good work on this!

As a small personal request (my little selfish wish), could you please add me as a co-author to this PR?

FYI

Co-authored-by: Wh1isper <[email protected]>

@Kludex
Copy link
Member Author

Kludex commented Feb 26, 2025

I'm going to have to rework this a bit. I'll continue my work tomorrow.

@Kludex
Copy link
Member Author

Kludex commented Feb 28, 2025

@Kludex
Copy link
Member Author

Kludex commented Feb 28, 2025

Does AWS Bedrock supports using the OpenAI API natively, or do we need to use the Converse API?

@Wh1isper
Copy link
Contributor

Does AWS Bedrock supports using the OpenAI API natively, or do we need to use the Converse API?

Bedrock does not support openai api, there is a project to proxy converse api to openai api: https://github.com/aws-samples/bedrock-access-gateway

For anthropics' models, we can use AsyncAnthropicBedrock, but if we want to use aws's models(e.g. nova) or llama model on bedrock, Converse API is the next generation standard to replace Invoke API with LLMs.

@Kludex
Copy link
Member Author

Kludex commented Feb 28, 2025

Right, so this PR is still needed. 👍

Thanks.

@Kludex
Copy link
Member Author

Kludex commented Mar 7, 2025

Pipeline passing. I'll do my usual self review.

@Kludex
Copy link
Member Author

Kludex commented Mar 7, 2025

We still need to add the other inputs i.e. ImageUrl, and BinaryContent, but I'll merge without supporting it.

@Kludex Kludex merged commit 6f991cb into main Mar 7, 2025
17 checks passed
@Kludex Kludex deleted the support-bedrock branch March 7, 2025 10:32
@Kludex
Copy link
Member Author

Kludex commented Mar 7, 2025

Thanks @Wh1isper 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for AWS Bedrock
2 participants