Skip to content

Port Image to C code #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

MightyJosip
Copy link
Member

This PR converts pygame._sdl2.video.Image to C code. It has the implementation of all the Image methods and attributes. It doesn't have docs/type hints/tests or stuff like that.

Leaving this as the draft atm, because it depends on #3317, #3327 and #3330, pushing just for the internal testing purposes

commit 813f384
Author: Josip Komljenović <[email protected]>
Date:   Wed Jan 29 15:43:45 2025 +0100

    Add interface for _sdl2.video classes

commit 702958c
Author: Josip Komljenović <[email protected]>
Date:   Wed Jan 29 15:38:01 2025 +0100

    Add interface for _sdl2.video classes

commit 081b032
Author: Josip Komljenović <[email protected]>
Date:   Wed Jan 29 15:33:20 2025 +0100

    Add interface for _sdl2.video classes

commit c9ffd1c
Author: Josip Komljenović <[email protected]>
Date:   Wed Jan 29 15:25:10 2025 +0100

    Add interface for _sdl2.video classes
commit 813f384
Author: Josip Komljenović <[email protected]>
Date:   Wed Jan 29 15:43:45 2025 +0100

    Add interface for _sdl2.video classes

commit 702958c
Author: Josip Komljenović <[email protected]>
Date:   Wed Jan 29 15:38:01 2025 +0100

    Add interface for _sdl2.video classes

commit 081b032
Author: Josip Komljenović <[email protected]>
Date:   Wed Jan 29 15:33:20 2025 +0100

    Add interface for _sdl2.video classes

commit c9ffd1c
Author: Josip Komljenović <[email protected]>
Date:   Wed Jan 29 15:25:10 2025 +0100

    Add interface for _sdl2.video classes
@MightyJosip MightyJosip mentioned this pull request Feb 7, 2025
60 tasks
@Starbuck5
Copy link
Member

@MightyJosip The other ones have been merged, now it's this PRs turn! Looks like it needs to be updated and done whatever needs to happen to get it ready for review.

Copy link
Contributor

coderabbitai bot commented Aug 26, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MyreMylar
Copy link
Member

I did a little bit of the merging work so we can see what we are working with here. Still needs tests and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants