Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for GET /observations v2 #490

Merged
merged 6 commits into from
May 29, 2023
Merged

Add basic support for GET /observations v2 #490

merged 6 commits into from
May 29, 2023

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented May 29, 2023

Updates #155

@JWCook JWCook added the new endpoint Add a new API endpoint label May 29, 2023
@JWCook JWCook added this to the v1.0 milestone May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #490 (c85ea4c) into main (c5c14ec) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head c85ea4c differs from pull request most recent head 2372ba3. Consider uploading reports for the commit 2372ba3 to get more accurate results

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   95.13%   95.20%   +0.06%     
==========================================
  Files          57       59       +2     
  Lines        3127     3171      +44     
  Branches      596      602       +6     
==========================================
+ Hits         2975     3019      +44     
  Misses        113      113              
  Partials       39       39              
Impacted Files Coverage Δ
pyinaturalist/docs/templates.py 100.00% <ø> (ø)
pyinaturalist/v1/observations.py 96.61% <ø> (ø)
pyinaturalist/constants.py 100.00% <100.00%> (ø)
pyinaturalist/models/observation.py 96.42% <100.00%> (+0.23%) ⬆️
pyinaturalist/request_params.py 98.27% <100.00%> (ø)
pyinaturalist/v2/__init__.py 100.00% <100.00%> (ø)
pyinaturalist/v2/observations.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@JWCook JWCook merged commit e0b98c6 into main May 29, 2023
@JWCook JWCook deleted the v2 branch May 29, 2023 21:55
JWCook added a commit that referenced this pull request May 29, 2023
Add basic support for GET /observations v2
JWCook added a commit that referenced this pull request May 30, 2023
Add basic support for GET /observations v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new endpoint Add a new API endpoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant