-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] conditional_join
can return ragged_arrays where possible - PR no. 2
#1397
Conversation
🚀 Deployed on https://deploy-preview-1397--pyjanitor.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1397 +/- ##
==========================================
+ Coverage 89.07% 89.23% +0.15%
==========================================
Files 87 87
Lines 5374 5534 +160
==========================================
+ Hits 4787 4938 +151
- Misses 587 596 +9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving, @samukweku! Just one question re: documentation.
I also noticed that the project test coverage has significantly gone down to <90%. I might need to dig further, but this is definitely a sign that we may need to invest more in covering edge cases throughout the repo. |
This is the second part of a series of PRs that ultimately adds support for aggregations within
conditional_join
. where possible,ragged_arrays
can be returned to the user, either as slices or arrays of indices, which can be used inakimbo
, orawkward
orpyarrow
to aggregate the data. this should be faster than materializing the entire dataframe within pandas before aggregating.PR Description
Please describe the changes proposed in the pull request:
get_join_indices
functionThis PR relates to #1269 and #1396 .
Please tag maintainers to review.