Fix false positives for use-implicit-booleaness-not-comparison checks

[zenlyj]

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs

Description

Currently, the use-implicit-booleaness-not-comparison check is applied to expressions with chained comparison. The emitted message and suggested code correction seem inaccurate, and I can't seem to find existing functional tests indicating that this behavior is intended. Therefore, these changes will skip the check when chained comparison nodes are visited.

Take for example:

foo, bar = [1], []

assert foo != bar == []  # "foo == []" can be simplified to "not foo", if it is strictly a sequence, as an empty list is falsey

foo != bar == [] is equivalent to foo != bar and bar == [], which is not the same as not foo.

Similar for use-implicit-booleaness-not-comparison-to-zero and use-implicit-booleaness-not-comparison-to-string.

Closes #10065

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (d17bb06) to head (187e34f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10246   +/-   ##
=======================================
  Coverage   95.85%   95.86%           
=======================================
  Files         175      175           
  Lines       19056    19058    +2     
=======================================
+ Hits        18267    18269    +2     
  Misses        789      789           

Files with missing lines	Coverage Δ
...heckers/refactoring/implicit_booleaness_checker.py	100.00% <100.00%> (ø)

[DanielNoord]

Could you add a changelog? Rest of the changes LGTM!

[Pierre-Sassoulas]

Change looks great, the primer looks amazing (I realized that we had a bug in the message for some chained comparisons they were not displayed in full but now it's gone, so.. good)

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are no longer emitted:

1. use-implicit-booleaness-not-comparison-to-string:
   "y == m == d == ''" can be simplified to "not d", if it is strictly a string, as an empty string is falsey
   https://github.com/django/django/blob/240421c7c4c81fe5df26274b807266bd4ca73d7f/django/forms/widgets.py#L1256

Effect on pandas:
The following messages are no longer emitted:

1. use-implicit-booleaness-not-comparison-to-zero:
   "0 != lplane_indexer" can be simplified to "lplane_indexer", if it is strictly an int, as 0 is falsey
   https://github.com/pandas-dev/pandas/blob/6bd74fab5f2dfe3512ecbd2797808399411bd452/pandas/core/indexing.py#L1984
2. use-implicit-booleaness-not-comparison-to-zero:
   "nobs == 0" can be simplified to "not nobs", if it is strictly an int, as 0 is falsey
   https://github.com/pandas-dev/pandas/blob/6bd74fab5f2dfe3512ecbd2797808399411bd452/pandas/core/_numba/kernels/sum_.py#L139
3. use-implicit-booleaness-not-comparison-to-zero:
   "0 == min_periods" can be simplified to "not min_periods", if it is strictly an int, as 0 is falsey
   https://github.com/pandas-dev/pandas/blob/6bd74fab5f2dfe3512ecbd2797808399411bd452/pandas/core/_numba/kernels/sum_.py#L139
4. use-implicit-booleaness-not-comparison-to-zero:
   "values.shape[0] == 0" can be simplified to "not values.shape[0]", if it is strictly an int, as 0 is falsey
   https://github.com/pandas-dev/pandas/blob/6bd74fab5f2dfe3512ecbd2797808399411bd452/pandas/core/internals/construction.py#L341

Effect on sentry:
The following messages are no longer emitted:

1. use-implicit-booleaness-not-comparison-to-zero:
   "p75 == 0" can be simplified to "not p75", if it is strictly an int, as 0 is falsey
   https://github.com/getsentry/sentry/blob/5dd543a208decc6fb5000a6d1c75a92ad90107c8/src/sentry/relay/config/metric_extraction.py#L1448
2. use-implicit-booleaness-not-comparison-to-zero:
   "duration % 3600 == 0" can be simplified to "not duration % 3600", if it is strictly an int, as 0 is falsey
   https://github.com/getsentry/sentry/blob/5dd543a208decc6fb5000a6d1c75a92ad90107c8/src/sentry/search/events/builder/utils.py#L58
3. use-implicit-booleaness-not-comparison-to-zero:
   "duration % 86400 == 0" can be simplified to "not duration % 86400", if it is strictly an int, as 0 is falsey
   https://github.com/getsentry/sentry/blob/5dd543a208decc6fb5000a6d1c75a92ad90107c8/src/sentry/search/events/builder/utils.py#L66

This comment was generated for commit 187e34f