Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release test #7523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove release test #7523

wants to merge 1 commit into from

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Oct 3, 2024

Failed last time probably because of python3.7 (should we bump the build python as well).

Removed as @maresb thinks it's useless.


📚 Documentation preview 📚: https://pymc--7523.org.readthedocs.build/en/7523/

@ricardoV94 ricardoV94 added release Github CI/CD no releasenotes Skipped in automatic release notes generation labels Oct 3, 2024
@ricardoV94 ricardoV94 requested a review from maresb October 3, 2024 09:54
@@ -16,14 +16,6 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: 3.7
# TODO: ideally, this pipeline should run parallelized tests in upstream jobs..
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this comment is about, to rerun the tests before uploading?

Copy link
Contributor

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'd never actually looked at this workflow but it is awful! It's using a very old python and it's also using twine?!? I think that pytensor has a much more modern approach to the upload process. Might be worth opening an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github CI/CD no releasenotes Skipped in automatic release notes generation release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants