Skip to content

chore: use dependency-groups #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

henryiii
Copy link
Contributor

Use dependency-groups, drop the [test]/[docs]/[typing] extras.

@henryiii henryiii force-pushed the henryiii/chore/depgrps branch 2 times, most recently from 7c13aad to f5b5c99 Compare April 2, 2025 04:18
@henryiii
Copy link
Contributor Author

henryiii commented Apr 2, 2025

pre-commit.ci autofix

@henryiii henryiii force-pushed the henryiii/chore/depgrps branch 2 times, most recently from ff850e2 to 087163a Compare May 6, 2025 14:36
@henryiii henryiii force-pushed the henryiii/chore/depgrps branch from 087163a to e79ea92 Compare May 14, 2025 04:11
@henryiii henryiii force-pushed the henryiii/chore/depgrps branch from e79ea92 to 4f18fbc Compare May 14, 2025 18:42
@layday
Copy link
Member

layday commented May 14, 2025

pip supports dependency groups now - can we use it?

@henryiii
Copy link
Contributor Author

Sure, but where? We are using tox so I don't think we need it anywhere? But yes, --group in uv or pip will work.

@henryiii
Copy link
Contributor Author

henryiii commented May 14, 2025

If you mean in readthedocs, uv is faster. Upgrading pip then pip installing with a group would work, but would be slower. Both have native support.

@layday
Copy link
Member

layday commented May 14, 2025

Sorry, I did mean in RTD. Just seems slightly odd to rely on asdf here - I'd prefer if there was a "blessed" way to use uv. If there isn't, maybe we should stick to pip?

@henryiii
Copy link
Contributor Author

asdf is the recommendation from the RtD team, and that's what they use to set things up too. If you request python, it gets installed with asdf. They do have caching for some modules (not uv), but it's only a second or two, and cuts the docs time in more than half usually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants