-
Notifications
You must be signed in to change notification settings - Fork 3.1k
doc: Explain how to query values for --platform and --python-version #13251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Explain how to query values for --platform and --python-version #13251
Conversation
…parameters of the download command is provided
The docs you've writen here don't seem to match the last comment in the thread you are referencing #6369 (comment) Taking a looking at Can you please justify your choices here, or update to reflect the discussion in #6369, |
I have delved into the problem in more detail and agree with your comment. I added the command |
I've put it on the 25.1 milestone so it doesn't get forgotten, but will need a maintainer to review and accept, I'll try but I can't promise anything. |
Even though this is "only" a docs change, there seem to be questions about the information given, and personally I'm not that convinced we should get into this much detail (these are advanced options, and cross-platform environment identification is a complex subject that I don't think it's pip's place to explain). I'm not rejecting this change, but I don't think there's any reason it should be targeted to a specific pip release, so I'm removing the 25.1 milestone. It can go in when it's ready. |
I'll review this week. As a pip user I am occasionally frustrated with options that are not clear to me where the values are derived or validated against. So I would like to see more documentation either pointing users to standards or detailing pip's implementation choices. I added the milestone not because I thought it was needed for 25.1 but rather a reminder to address this PR in some way or another, rather than forgetting about it. I'm happy to take responsibility to review, reject, or postpone PRs that I add to a milestone that are otherwise left unreviewed and unmerged. |
No worries - I'm happy for it to go in or not, as you prefer. But as we get closer to the release, I want the milestone to reflect stuff that I need to ensure gets resolved, and I don't think this falls into that category, which is why I removed it. |
I'll merge in a couple of days if there is no objection. There are some minor differences compared to how pip validates against these values, but upon reviewing I really think these are implementation details and the methods in this PR are the correct methods users should check against. I’m happy this removes the mystery of what these values are for users. |
Thanks for the review, I was glad to work for pip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not enthusiastic for this, but I also have no objections to merging this. I left some comments on the mechanics.
Fixes #6369