Door flip state

[mangrove-art]

Door flip state

Description

This script writes the mirror state (aka Left/Right) of doors back to an instance parameter 'Door Wing Opening Direction' in doors.

---

Checklist

Before submitting your pull request, ensure the following requirements are met:

• Code follows the PEP 8 style guide.
• Code has been formatted with Black using the command:

  pipenv run black {source_file_or_directory}

• Changes are tested and verified to work as expected.

---

Thank you for contributing to pyRevit! 🎉

[devloai]

PR Summary:

This PR adds a new script for analyzing and updating door mirror states. It writes the mirror state (Left/Right) of doors to an instance parameter called 'Door Wing Opening Direction'. The script identifies mirrored vs. standard door configurations and updates a parameter that can be used for documentation or scheduling. It includes thorough error handling for doors without the required parameters and provides a detailed report of changes made.

Review Summary:

The code successfully implements the intended functionality but contains a few critical issues that should be addressed. The most significant concern is calling sys.exit() within a transaction, which could leave the document in an inconsistent state. There are also some empty exception handlers that make debugging difficult, and a performance optimization opportunity with repeated parameter lookups. Feel free to provide feedback on this review for future improvements.

Follow-up suggestions:

@devloai fix the transaction handling to ensure the document remains in a consistent state

[Copilot]

Pull Request Overview

This PR adds a script that writes the mirror state of doors back to an instance parameter and updates the corresponding bundle metadata.

• Implements a new script (script.py) to update door mirror state via shared parameters.
• Updates the bundle.yaml with multilingual labels and tooltips for the pushbutton.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

File	Description
script.py	Implements door mirror state update logic with shared parameter writebacks and summary reporting.
bundle.yaml	Provides multilingual title, tooltip, and author metadata for the pushbutton.

Comments suppressed due to low confidence (1)

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Analyse.pulldown/Door Mirror State.pushbutton/script.py:48

• [nitpick] The error message for a missing parameter is unclear. Consider rephrasing it to: "Please create the instance parameter 'Door Wing Opening Direction' with the option for different values for group instances in the Doors category."

Please create the parameter as an instance parameter, option different values for groupes,

[jmcouffin]

@mangrove-art Cool.
Question:
Do you really need all these parameters?

• IMO creating parameters within a routine will refrain people to actually use it
• You would not have to check for parameters existence
• You could color and isolate in dedicated views: mirrored and inverted doors (and their host walls) each in a different color

If you feel like sticking with the parameters approach, I suggest you use only project parameters and create them while in the script, and have a routine to delete them afterward.

[mangrove-art]

@mangrove-art Cool. Question: Do you really need all these parameters?

* IMO creating parameters within a routine will refrain people to actually use it

* You would not have to check for parameters existence

* You could color and isolate in dedicated views:  mirrored and inverted doors (and their host walls) each in a different color

If you feel like sticking with the parameters approach, I suggest you use only project parameters and create them while in the script, and have a routine to delete them afterward.

Actually your thoughts are perfectly right although I cannot follow your advices. Let me explain.

1. The project parameter called "Door Wing Opening Direction" is used to get the values in schedules, annotations and filters in specific views. I didn't want to missuse a builtin parameter to be explicit in meaning of the acquired information. As a parameter file is provided in the script folder it seems quite easy to create the parameter.

2. The two parameters called "DoorFamilyOpeningDirection_standard" and "DoorFamilyOpeningDirection_mirrored" reflected for me the easyiest way to deal with different standard door swing directions modelled families in an existing project. They allow a liberty to provide f.ex. the same return value for both states like the case of a sliding door where the swing opening direction is not clearly defined. Also they allow to handle complex situations where a door is part of a panel and both can be mirrord, see image joined.
   Overall it was the most simpliest way to deal with all geometric exeptions for me. I recognize that is not a simple solution to the problem. @jmcouffin What do you think?