Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types types to handlers module #1941

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

juanitorduz
Copy link
Contributor

Continue adding more type hints :)

@juanitorduz juanitorduz marked this pull request as draft December 25, 2024 20:29
Comment on lines +86 to +89
self,
exc_type: Optional[type[BaseException]],
exc_value: Optional[BaseException],
traceback: Optional[TracebackType],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanitorduz juanitorduz marked this pull request as ready for review December 26, 2024 08:18
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @juanitorduz!

@fehiepsi fehiepsi merged commit e5fc673 into pyro-ppl:master Dec 27, 2024
10 checks passed
@juanitorduz juanitorduz deleted the types-handlers branch December 27, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants