Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pyro.poutine.handlers #3283

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix pyro.poutine.handlers #3283

merged 1 commit into from
Oct 19, 2023

Conversation

ordabayevy
Copy link
Member

@ordabayevy ordabayevy commented Oct 19, 2023 •
edited
Loading

Two fixes:

  • PlateMessenger is not used in this file and not imported from it
  • MarkovMessenger from the _msngrs list is used to add markov variable to the locals() but then markov is redefined. So I believe MarkovMessenger can be removed from _msngrs

@ordabayevy ordabayevy added the bug label Oct 19, 2023
fritzo
fritzo approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, I doubt anyone is importing PlateMessenger from pyro.poutine.handlers.

@fritzo fritzo merged commit ffc5e24 into dev Oct 19, 2023
9 checks passed
@ordabayevy ordabayevy deleted the fix-handlers branch October 19, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ordabayevy @fritzo