-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertex/Arc ID sorting bug in Network.split_arcs() #535
Conversation
All tests are passing locally ( |
Passing:
Python 3.6 on Windows failing due to an issue with |
The |
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
========================================
+ Coverage 97.6% 97.9% +0.3%
========================================
Files 3 3
Lines 1136 1143 +7
Branches 284 286 +2
========================================
+ Hits 1109 1119 +10
+ Misses 6 4 -2
+ Partials 21 20 -1
|
The current commit will fail, but we'll merge anyway in the hopes the |
Version bump for bug fix (#535)
This PR addresses #526.
The were 2 sorting issues happening here.
set
after the network was split. When the arcs are fed intolibpysal.weights.W
it expects sorted IDs, this is what was causing all the counts all over the place.