-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: use of indices in numpy 1.24.1 #47
base: develop-3
Are you sure you want to change the base?
Conversation
The changelog was screwed up when I merged #41. Not sure how to fix this. |
Pulled text from a previous commit
OK, I pulled the text from before the merge. Essentially, the merge duplicated the 3.2 refs and added the 4.0 stuff to the second 3.2. Should be back up to standard now. |
@rstoneback, we have a numpy version cap at pysatNASA that needs a patch version here. |
@@ -569,7 +569,7 @@ def _process_return_multi_z_attr(self, data, attr_names, var_names, | |||
chars.append('*') | |||
self.meta[var_name][attr_name] = ''.join(chars).rstrip() | |||
else: | |||
self.meta[var_name][attr_name] = data[i, 0:num_e] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this change. But I don't think I understand why this was producing an error.
The documentation for indexing has examples in the "Advanced Indexing" section that look the same as data[i, 0:num_e]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see data access examples like data[I, j] in the documentation. I don't quite understand why this change is needed.
Just going to drop a little reminder that all versions of numpy currently supported by pysatCDF have officially reached end of life as of 24 Jun 2024. |
Description
Addresses #46
numpy 1.24.1 doesn't like how the indices work.
Type of change
How Has This Been Tested?
This has only been tested via github actions. It needs a human in the loop to verify that data is loaded as expected. I cannot compile on my local machine.
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release