Added more LoS load options #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more methods for loading the LoS TEC data.
Added a new section to the changelog.
Updated the TEC example to express available data and show how to use the selective LoS loading.
Added a note about the support functions that exist to help load data by site or time.
Changed datetime calls to `utcnow`, as it has been deprecated.
Added additional changes to the log.
Remove unnecessary information from timestamps.
Updated the logger to use pysat directly instead of importing it from pysat.
Fixed the datetime class reference.
rstoneback
reviewed
Sep 5, 2024
aburrell
commented
Sep 5, 2024
Added inline and block comments to show filtering motivation.
jklenzing
reviewed
Sep 7, 2024
There was a problem hiding this comment.
Looks good. I would recommend adding the if: ${{ always() }} line to the "finish" job in the main workflow so that the final coverage step is run even if some of the env configs (eg, python 3.6.8) fail. This should at least be documented in an issue.
On a quasi-related note, I've been having issues getting coveralls to display the actual files when the coveralls app is used. :(
Update the test finish conditions as suggested by @jklenzing.
jklenzing
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #103 and expands the options for loading line-of-site TEC data.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran the example in the docs. Tried various combinations of loading line of site data.
Test Configuration
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release