-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to hatch + move importlib hacks to own module for typing #362
base: main
Are you sure you want to change the base?
Conversation
readthedocs seems to lack support for modern builds |
3be69a7
to
49a4877
Compare
fixed the issues, will need to add some docs later today |
49a4877
to
86de9be
Compare
@pytest-dev/core this also serves as first example for going away from setuptools, please have a look |
will squash locally after approval |
Will reorder the commit content today to split the meaning |
0af7926
to
2c8248d
Compare
@nicoddemus i'd appreciat another look over before merging the split commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: Implementation :: CPython", | ||
"Programming Language :: Python :: Implementation :: PyPy", | ||
"Programming Language :: Python :: 3.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Programming Language :: Python :: 3.9", | |
"Programming Language :: Python :: Implementation :: CPython", | |
"Programming Language :: Python :: Implementation :: PyPy", | |
"Programming Language :: Python :: 3.10", | |
"Programming Language :: Python :: 3.9", | |
"Programming Language :: Python :: 3.10", | |
"Programming Language :: Python :: Implementation :: CPython", | |
"Programming Language :: Python :: Implementation :: PyPy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it now, the tool seems to work as expected.
I think we should also update the deploy
workflow to use hatch, after all its main purpose is to do the build (and maybe publish) no?
"Topic :: Utilities", | ||
] | ||
dependencies = [ | ||
"importlib-metadata>=0.12;python_version<\"3.8\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think can use '
here to avoid the escaping
"importlib-metadata>=0.12;python_version<\"3.8\"", | |
'importlib-metadata>=0.12;python_version<"3.8"', |
@bluetech good catch, I think you mean these places? pluggy/.github/workflows/main.yml Line 145 in 70fde45
pluggy/.github/workflows/main.yml Line 112 in 70fde45
pluggy/.github/workflows/main.yml Line 148 in 70fde45
|
Yes exactly. I'm not sure if we want to keep using the |
hooks: | ||
- id: blacken-docs | ||
additional_dependencies: [black==21.7b0] | ||
additional_dependencies: [black==22.6.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match the one above:
additional_dependencies: [black==22.6.0] | |
additional_dependencies: [black==22.8.0] |
@@ -1,4 +1,5 @@ | |||
[tox] | |||
isolated_build = True | |||
envlist=linting,docs,py{36,37,38,39,310,py3},py{36,37}-pytest{main} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
envlist=linting,docs,py{36,37,38,39,310,py3},py{36,37}-pytest{main} | |
envlist=linting,docs,py{37,38,39,310,py3},py{37}-pytest{main} |
There is an issue: |
I am against this as I prefer setuptools-scm, but I will not block the change. |
Hatch VCS uses Setuptools-scm |
This is currently indefinitely blocked as the dependency loop with hatchling needs a resolution |
Do I understand right that only migration to hatchling is blocked, but the rest of changes ("move importlib hacks to own module for typing") are not blocked. |
No description provided.