Skip to content

Simplify synchronizers #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2025
Merged

Conversation

seifertm
Copy link
Contributor

This is a refactoring patch aiming to simplify the logic of synchronizers in the code. It is best reviewed commit by commit.

seifertm added 6 commits June 25, 2025 19:04
Previously, synchronizers modified the obj attribute of a function item permanently. This could possibly result in multiple levels of wrapping.
This patch restores the original function object after the test finished.
This also fixes an issue that could cause the warning for the deprecated *scope* argument to the asyncio marker to be reported multiple times.
@seifertm seifertm added this to the v1.1 milestone Jun 25, 2025
@seifertm seifertm requested review from asvetlov and Tinche as code owners June 25, 2025 17:06
@seifertm seifertm added this pull request to the merge queue Jun 27, 2025
Merged via the queue into pytest-dev:main with commit b6deb15 Jun 27, 2025
20 of 21 checks passed
@seifertm seifertm deleted the simplify-synchronizers branch June 27, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant