Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display full param name asyncio_default_fixture_loop_scope #990

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

MarkusBiggus
Copy link
Contributor

confirmed verbose output displays correct name:

asyncio: mode=Mode.AUTO, asyncio_default_fixture_loop_scope=function

file version not present and I don't understand the issue described in setup.cfg

guessed version in changelog.rst with totally random date (my birthday)

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (dbf9991) to head (f264dcd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files           2        2           
  Lines         513      513           
  Branches       66       66           
=======================================
  Hits          466      466           
  Misses         28       28           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seifertm seifertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for leaving this open for such a long time. The change absolutely makes sense.

I rebased the branch, addressed the conflict, and squashed the commit that was added by "pre-commit ci".

With regards to your questions:
For new versions, we usually use the date "UNRELEASED".
The _version.py file is generated by setuptools_scm when packaging the plugin into an sdist/Python wheel. Setuptools_scm derives the project version from the tags of the Git repository. That means we can create new releases by creating an appropriate Git tag.

These things should be mentioned in a contribution guide and/or the documentation, so thanks for pointing out the deficiencies :)

@seifertm seifertm added this pull request to the merge queue Dec 6, 2024
@seifertm seifertm added this to the v0.25 milestone Dec 6, 2024
Merged via the queue into pytest-dev:main with commit a1cd861 Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants