Exposes the underlining TestCase instance to avoid using "asserts" module

[kingbuzzman]

Related to issue: #1155

[kingbuzzman]

@bluetech thoughts?

[bluetech]

I have a (vain?) hope that someday pytest will be thread safe (i.e. specifically, it should be possible to run multiple pytest instances concurrently in the same process). Currently it isn't, and even pytest-django adds some issues itself. But I think it better to avoid adding new ones.

I think if we decide that's it worth putting effort into this issue, we should find a way to make the assert "bind" to the test it is running under. And if there's no clean way to do that, then consider an alternative interface which does make it possible (e.g. a django_assert fixture or such which binds to the current test via request and exposes the assertions as methods, e.g. django_assert.templateUsed()).

[kingbuzzman]

But I think it better to avoid adding new ones.

This makes sense.

find a way to make the assert "bind" to the test it is running under.

I have some ideas on how to make this work

[kingbuzzman]

@bluetech what do you think of this approach?

[Copilot]

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

• docs/helpers.rst: Language not supported

[Copilot]

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)

• docs/helpers.rst: Language not supported

Comments suppressed due to low confidence (2)

pytest_django/fixtures.py:221

• [nitpick] The fixture name 'django_testcase_class' might be ambiguous; consider renaming it to 'DjangoTestCaseClass' to clearly indicate that it returns a TestCase class.

def django_testcase_class(

pytest_django/asserts.py:34

• [nitpick] The deprecation warning message could be made clearer by explicitly specifying the recommended usage of the 'django_testcase' fixture along with its attributes.

message = (

[kingbuzzman]

@bluetech thoughts how I can improve this?

[bluetech]

@kingbuzzman That's a creative solution, I like it! I will definitely try to review this before the next release.

[adamchainz]

I think the fixture will make tests too verbose, and the deprecation will cause unnecessary churn. I think it would be better with a shorter fixture name and a retention of the asserts module. Perhaps the asserts module can be rewritten with wrapper functions that call the fixture methods?

[kingbuzzman]

@adamchainz understand the making the fixture name smaller, but now sure about how the wrapper would work without frame hacking.. can you provide an example?

[kingbuzzman]

What do you guys think of renaming "django_testcase" to just djtc it's 4 characters, similar to "self"? I'm open for suggestions