feat: refactor pyth lazer protocol #2945
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
danimhr
approved these changes
Aug 12, 2025
| @@ -7,7 +7,7 @@ license = "Apache-2.0" | |||
| repository = "https://github.com/pyth-network/pyth-crosschain" | |||
|
|
|||
| [dependencies] | |||
| pyth-lazer-protocol = { version = "0.11.0", path = "../../sdk/rust/protocol" } | |||
| pyth-lazer-protocol = { version = "0.12.0", path = "../../sdk/rust/protocol" } | |||
There was a problem hiding this comment.
There is function name change.
Riateche
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Thanks! Yeah, of course it's "with_same_exponent", not "with_same_mantissa".
Sadly I already bumped versions and published them after my PR, so you'll need to bump versions again. Patch bump is probably enough, since new versions haven't been used anywhere yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refactor pyth lazer protocol to be more readable and have consistent variable/function names for
value,mantissa, andexponentthat follows the following formulavalue = mantissa * 10^exponentRationale
The code was hard to understand
How has this been tested?
ran tests