fix: resolve circular Suspense fallback causing infinite loading in Entropy explorer #2991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…ntropy explorer - Replace self-referencing Paginator fallback with PaginatorImpl isPending prop - Follows same pattern as other components (SearchBar, StatusSelect) - Fixes infinite loading animation that persisted after content loaded Co-Authored-By: Jayant <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
…error - Add ESLint disable comments for empty arrow functions in loading state - Maintain proper Paginator component props interface - Resolve TypeScript compilation error while preserving infinite loading fix Co-Authored-By: Jayant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a circular Suspense fallback in the Paginator component that was causing infinite loading animations in the Entropy explorer app. The fallback was self-referencing (
<Paginator {...props} />), preventing the Suspense boundary from ever resolving.Rationale
The Entropy explorer was displaying content correctly but showed a persistent loading animation in the browser. This was caused by the Paginator component's Suspense fallback creating a circular reference - the component was trying to render itself as its own loading fallback, creating an infinite loop that prevented the Suspense from settling.
The fix replaces the self-referencing fallback with
<PaginatorImpl isPending {...props} />, following the same pattern used by other components in the file (SearchBar, StatusSelect, ChainSelect).How has this been tested?
Manual testing steps:
Reviewer Checklist:
Link to Devin run: https://app.devin.ai/sessions/e89852faa4ea45148c336c6620dcc95c
Requested by: Jayant ([email protected])