Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster mode support #420

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adds cluster to CI
jeanluciano committed Nov 14, 2023
commit bc546f67c378301c29dea6788a6d8410e9db2553
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -78,6 +78,16 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Test redis cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add cluster tests separately from the main tests as redis-cluster-test.

uses: vishnudxb/redis-cluster@1.0.9
with:
master1-port: 5000
master2-port: 5001
master3-port: 5002
slave1-port: 5003
slave2-port: 5004
slave3-port: 5005
sleep-duration: 5

- name: set up python
uses: actions/setup-python@v4
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
@@ -54,7 +54,7 @@ async def arq_redis_msgpack(loop):

@pytest.fixture
async def arq_redis_cluster(loop):
settings = RedisSettings(host='localhost', port='6379', conn_timeout=5, cluster_mode=True)
settings = RedisSettings(host='localhost', port='5000', conn_timeout=5, cluster_mode=True)
redis_ = await create_pool(settings)
await redis_.flushall()