Skip to content

Fix "retry_on_error" type annotation #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix "retry_on_error" type annotation #446

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b080b8
Fix "retry_on_error" type annotation
armicron Apr 19, 2024
ae148a0
Merge branch 'main' into armicron/type_annotation
armicron May 3, 2024
965fdfd
Merge branch 'main' into armicron/type_annotation
armicron Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions arq/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from dataclasses import dataclass
from datetime import datetime, timedelta
from operator import attrgetter
from typing import TYPE_CHECKING, Any, Callable, List, Optional, Tuple, Union, cast
from typing import TYPE_CHECKING, Any, Callable, List, Optional, Tuple, Type, Union, cast
from urllib.parse import parse_qs, urlparse
from uuid import uuid4

Expand Down Expand Up @@ -50,7 +50,7 @@ class RedisSettings:
sentinel_master: str = 'mymaster'

retry_on_timeout: bool = False
retry_on_error: Optional[List[Exception]] = None
retry_on_error: Optional[List[Type[Exception]]] = None
retry: Optional[Retry] = None

@classmethod
Expand Down