Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyright tests to match expected pyright output after pyright 1.1.380 #1381

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

filbranden
Copy link
Contributor

Summary

Update the pyright test to match output after pyright 1.1.380, this change was introduced in microsoft/pyright#8896 and the posted comment from github-actions bot in that PR shows the expected diff on attrs.

Fixes #1347.

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!
  • Added tests for changed code.
  • (N/A) New features have been added to our Hypothesis testing strategy.
  • (N/A) Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
  • (N/A) Updated documentation for changed code.
  • (N/A) Documentation in .rst and .md files is written using semantic newlines.
  • (N/A) Changes (and possible deprecations) have news fragments in changelog.d.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

@hynek hynek added this pull request to the merge queue Dec 9, 2024
Merged via the queue into python-attrs:main with commit 2a76643 Dec 9, 2024
17 checks passed
@filbranden filbranden deleted the pyright1 branch December 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyright 1.1.380 broke our tests
2 participants