Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.0 - Removing all format_ wrappers, cleanups, and code quality. #174

Closed
wants to merge 4 commits into from

Conversation

TkTech
Copy link
Contributor

@TkTech TkTech commented Aug 28, 2020

We currently (v1, v2) duplicate all of the babel.dates and babel.numbers format_* methods in Flask-Babel. This is a lot of completely unnecessary duplication, including docstrings and test coverage. We're also often out of date with babel's methods, such as when new kwargs are added. Just like flask-wtf did way back, we should chuck this and become just the glue layer between Flask and Babel. In general, the only change in your code is to add format_decimal(..., locale=get_locale()).

Because this PR reduces our surface area significantly, lets make it a goal to get 100% test coverage.

The v3.* family aims to be the last breaking release for quite awhile.

@TkTech TkTech self-assigned this Aug 28, 2020
@TkTech TkTech changed the title v3.0.0 - Removing all format_ wrappers. v3.0.0 - Removing all format_ wrappers, cleanups, and code quality. Aug 28, 2020
@TkTech TkTech closed this Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant