v3.0.0 - Removing all format_ wrappers, cleanups, and code quality. #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently (v1, v2) duplicate all of the babel.dates and babel.numbers
format_*
methods in Flask-Babel. This is a lot of completely unnecessary duplication, including docstrings and test coverage. We're also often out of date with babel's methods, such as when new kwargs are added. Just like flask-wtf did way back, we should chuck this and become just the glue layer between Flask and Babel. In general, the only change in your code is to addformat_decimal(..., locale=get_locale())
.Because this PR reduces our surface area significantly, lets make it a goal to get 100% test coverage.
__init__
and test code. (%
vsformat()
). Or bump to py3.6+ and use fstrings.The v3.* family aims to be the last breaking release for quite awhile.