add has_upper_bound method to VersionConstraint

[radoering]

Required for python-poetry/poetry#10146

• Added tests for changed code.
• Updated documentation for changed code.

Summary by Sourcery

Tests:

• Add tests for the has_upper_bound method.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds a has_upper_bound method to the VersionConstraint class and implements it for the existing constraint types.

Class diagram for VersionConstraint hierarchy with new has_upper_bound method

classDiagram
    class VersionConstraint {
        <<abstract>>
        +is_any(): bool
        +is_simple(): bool
        +has_upper_bound(): bool
        +allows(version: Version): bool
    }
    class EmptyConstraint {
        +is_any(): bool
        +is_simple(): bool
        +has_upper_bound(): bool
        +allows(version: Version): bool
    }
    class VersionRangeConstraint {
        +allowed_max(): Version
        +has_upper_bound(): bool
        +allows_lower(other: VersionRangeConstraint): bool
    }
    class VersionUnion {
        -_ranges: List[VersionConstraint]
        +is_any(): bool
        +is_simple(): bool
        +has_upper_bound(): bool
        +allows(version: Version): bool
    }

    VersionConstraint <|-- EmptyConstraint
    VersionConstraint <|-- VersionRangeConstraint
    VersionConstraint <|-- VersionUnion

    note for VersionConstraint "New abstract method has_upper_bound added"
    note for EmptyConstraint "Always returns True"
    note for VersionRangeConstraint "Returns True if max is not None"
    note for VersionUnion "Returns True if all constraints have upper bounds"

Loading

File-Level Changes

Change	Details	Files
Introduce has_upper_bound method in VersionConstraint and implement it in subclasses.	Added abstract method has_upper_bound to VersionConstraint. Implemented has_upper_bound for EmptyConstraint to return True. Implemented has_upper_bound for VersionRangeConstraint to check if max is not None. Implemented has_upper_bound for VersionUnion to check if all constraints have an upper bound.	src/poetry/core/constraints/version/version_constraint.py src/poetry/core/constraints/version/empty_constraint.py src/poetry/core/constraints/version/version_range_constraint.py src/poetry/core/constraints/version/version_union.py
Add tests for the has_upper_bound method.	Added a new test case test_has_upper_bound with various constraints and expected results.	tests/constraints/version/test_version_constraint.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @radoering - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• The has_upper_bound() implementation is incorrect - it returns True when any constraint has no upper bound (link)

Overall Comments:

• The has_upper_bound() implementation in VersionUnion appears incorrect. It should return true only if ALL ranges have upper bounds, not if ANY range lacks an upper bound. The current logic is inverted.
• Documentation is missing for the new has_upper_bound() method. Please add docstrings explaining the method's purpose and behavior.

Here's what I looked at during the review

• 🔴 General issues: 1 blocking issue
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[radoering]

@sourcery-ai review

[sourcery-ai]

Hey @radoering - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please add documentation (docstrings) for the new has_upper_bound method explaining what it means for a version constraint to have an upper bound

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}