Implement preferred_import_style #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
==========================================
+ Coverage 94.97% 94.98% +0.01%
==========================================
Files 135 135
Lines 26404 26480 +76
==========================================
+ Hits 25076 25152 +76
Misses 1328 1328 ☔ View full report in Codecov by Sentry. |
This is a configuration option to select the import style that rope will use when adding new imports. Co-authored-by: Nicolas Zermati <[email protected]>
lieryan
force-pushed
the
lieryan-preferred-import-style
branch
from
1d13e5d
to
c4469af
Compare
lieryan
commented
Apr 8, 2024
|
Just tested this, it works nicely and results in much smaller diffs :) thanks! |
|
@lieryan it would be pretty awesome to be able to use this. Is there something that prevents it from being merged? Anything we could contribute with? |
|
Thanks for checking this PR out, @lheckemann. @nip3o nothing that I recall, I'll merge this now and include this in a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new setting (
imports.preferred_import_style) that controls how rope inserts new import statements.It can be set to:
normal-import(default) which will insert imports asimport <package>from-modulewhich will insert imports asfrom <package> import <module>from-globalwhich will insert imports asfrom <package>.<module> import <object>Credit: the solution here is based on nicoolas25's work on #696, but implements the config settings in a slightly different way.
Checklist (delete if not relevant):