Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require mypy < 1.7.0 #91

Closed

Conversation

CoolCat467
Copy link
Member

As per #90, this PR makes the project require mypy < 1.7.0

@jakkdl
Copy link
Member

jakkdl commented Nov 22, 2023

the failure is from this package not being updated since before trio 0.23, and we having made small changes to the API since. Dirty fix would be to add a requirement for trio==0.xx.yy - but if we're to release that we really want a warning somewhere that this package is deprecated.

@jakkdl jakkdl changed the title Requre mypy < 1.7.0 Require mypy < 1.7.0 Nov 22, 2023
@TeamSpen210
Copy link
Contributor

I don't think we can fix this via metadata changes. Pip will just go back in versions and use an earlier version of trio-typing that is "compatible".

@jakkdl
Copy link
Member

jakkdl commented Nov 23, 2023

oh right, derp.

@oremanj
Copy link
Member

oremanj commented Dec 1, 2023

Closed in favor of #92 which more properly supports mypy 1.7.

@oremanj oremanj closed this Dec 1, 2023
@CoolCat467 CoolCat467 deleted the require-mypy-lessthan-1.7.0 branch December 1, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants