Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-126890: Restore stripped ssl docstrings #127281

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Nov 26, 2024

In GH-124993, I forgot to carry over some of the docstrings to AC. This adds all of them back.

@encukou
Copy link
Member

encukou commented Nov 26, 2024

At a first glance at those warnings, it looks like this might need some changes in clinic :(
Shout if you want me to help.

@neonene
Copy link
Contributor

neonene commented Nov 26, 2024

Please add a docstring for _ssl.MemoryBIO.pending.

I think the warnings are related to the following regression:

3.12 on Windows:

>>> help(_ssl._SSLSocket.context)
Help on getset descriptor _ssl._SSLSocket.context:

context
    _setter_context(ctx)
    This changes the context associated with the SSLSocket. This is typically
    used from within a callback function set by the sni_callback
    on the SSLContext to change the certificate information associated with the
    SSLSocket before the cryptographic exchange handshake messages
>>>

This PR:

>>> help(_ssl._SSLSocket.context)
Help on getset descriptor _ssl._SSLSocket.context:

context

>>>

@ZeroIntensity
Copy link
Member Author

As far as I can tell, the warnings are a clinic bug.

@erlend-aasland
Copy link
Contributor

Can we tear out the Argument Clinic bug fix as a separate PR?

@ZeroIntensity
Copy link
Member Author

Yeah, I'll do that. A fair warning: it might take me a little while to get the PR up; I'm currently on a slow connection and GitHub takes forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants