Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127282: fix concurrent/future/thread.py: _python_exit #127283

Closed

Conversation

GoodenoughPhysicsLab
Copy link

@GoodenoughPhysicsLab GoodenoughPhysicsLab commented Nov 26, 2024

Copy link

cpython-cla-bot bot commented Nov 26, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 26, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! This needs a NEWS entry and a simple test (you'll probably need to add one to test_thread_pool).

I'm a little on the fence about this change, the timeout=2 feels a bit arbitrary, and I don't know how stable it is (this doesn't do anything for Linux, FWIW).

@GoodenoughPhysicsLab
Copy link
Author

should we use platforms.system(), and even fix join further

@GoodenoughPhysicsLab
Copy link
Author

it seems that there is no need to add a new dependence of platforms, I will have a try to add one to test.

@GoodenoughPhysicsLab
Copy link
Author

it's hard for me to add a test, because the program can't know that he is blocked.

@GoodenoughPhysicsLab
Copy link
Author

The problem of Thread.join have been fixed somewhere. Therefore, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants