Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127330: Update for OpenSSL 3.4 #127331

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

encukou
Copy link
Member

@encukou encukou commented Nov 27, 2024

Add git describe output to headers generated by make_ssl_data.py

IMO, this info is more important than the date when the file was generated.
It does mean that the tool now requires a Git checkout of OpenSSL, not for example a release tarball.

I've regenerated the older file to add the info. To the other older file I added a note about manual edits.

Add notes on how to add a new OpenSSL version

I believe that what I wrote is the correct process. ssl experts, do you want to you verify? @jackjansen, @tiran, @dstufft, @alex

Add 3.4 error messages and multissl tests

Hopefully we'll start getting fewer [SYS] unknown error in tests! (See #127257)

Also:
- Avoid the deprecated `datetime.datetime.utcnow()`
- Fix newline

This requires that the OpenSSL source tree is a Git checkout,
and that you have Git installed. Both should be fine for a tool
run manually by people who can change the tool.
@encukou encukou changed the title gh-27330: Update for OpenSSL 3.4 gh-127330: Update for OpenSSL 3.4 Nov 27, 2024
@encukou
Copy link
Member Author

encukou commented Nov 27, 2024

!buildbot Arch

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit ea72022 🤖

The command will test the builders whose names match following regular expression: Arch

The builders matched are:

  • AMD64 Arch Linux Perf PR
  • AMD64 Arch Linux Asan PR
  • AMD64 Arch Linux Valgrind PR
  • aarch64 Fedora Rawhide LTO PR
  • AMD64 Arch Linux Usan PR
  • aarch64 RHEL8 LTO PR
  • AMD64 Arch Linux TraceRefs PR
  • aarch64 Fedora Stable Clang PR
  • aarch64 Ubuntu 22.04 BigMem PR
  • aarch64 CentOS9 LTO + PGO PR
  • aarch64 Fedora Stable LTO + PGO PR
  • aarch64 Fedora Stable PR
  • aarch64 Fedora Rawhide Clang Installed PR
  • aarch64 CentOS9 LTO PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 RHEL8 Refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 Arch Linux Usan Function PR
  • aarch64 Fedora Rawhide Clang PR
  • aarch64 Android PR
  • aarch64 Fedora Rawhide PR
  • aarch64 CentOS9 Refleaks PR
  • aarch64 RHEL8 PR
  • AMD64 Arch Linux VintageParser PR
  • aarch64 Fedora Stable LTO PR
  • aarch64 Fedora Stable Clang Installed PR
  • aarch64 Fedora Rawhide NoGIL PR
  • aarch64 RHEL8 LTO + PGO PR
  • AMD64 Arch Linux Asan Debug PR
  • aarch64 Fedora Rawhide Refleaks PR

@alex
Copy link
Member

alex commented Nov 27, 2024

I think this looks right, but I've never actually done the process myself :-)

The only other thing we might want is bumping the version that's used in the Windows and macOS builds.

@ned-deily
Copy link
Member

I believe @gpshead has done these updates most recently.

@ned-deily
Copy link
Member

ned-deily commented Nov 27, 2024

The only other thing we might want is bumping the version that's used in the Windows and macOS builds.

Up to now, we've treated that as a separate decision, independent of what version(s) CPython supports. In particular, we have been taking the conservative approach and sticking with OpenSSL 3.0.x which is documented as that project's LTS version. We will eventually have to revisit that, i.e. before 2026-09-07, but it doesn't need to be part of this process.

@gpshead gpshead self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants