Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-131331: rename not field to invert for C++ extension modules #131334

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Mar 16, 2025

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename it to invert, please?

@picnixz picnixz changed the title gh-131331: rename not field to not_ for C++ extension modules gh-131331: rename not field to invert for C++ extension modules Mar 19, 2025
@picnixz
Copy link
Member Author

picnixz commented Mar 19, 2025

@brandtbucher Done! I'm leaving for a few days and I'll be offline. So if you want to change something, feel free to direclty edit my PR!

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brandtbucher brandtbucher merged commit 883c2f6 into python:main Mar 20, 2025
61 checks passed
@picnixz picnixz deleted the fix/jit/not-in-cpp-131331 branch March 22, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants