Skip to content

gh-136203: Improve TypeError msg when comparing two MappingProxyTypes #136204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 2, 2025

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a minor suggestion.

Co-authored-by: Victor Stinner <[email protected]>
@sobolevn sobolevn merged commit 41a9b46 into python:main Jul 2, 2025
70 of 73 checks passed
@sobolevn
Copy link
Member Author

sobolevn commented Jul 2, 2025

We generally don't backport error message changes. If needed - please, let me know :)

@sobolevn
Copy link
Member Author

sobolevn commented Jul 2, 2025

Thanks everyone!

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants