feat: new mypyc primitives for str.count #19264
Merged
+203
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
changed the title
JukkaL
reviewed
Jun 13, 2025
| string = "abcbcb" | ||
| assert string.count("a", 0, 4) == 1, string.count("a", 0, 4) | ||
| assert string.count("b", 0, 4) == 2, string.count("b", 0, 4) | ||
| assert string.count("c", 0, 4) == 1, string.count("c", 0, 4) |
There was a problem hiding this comment.
Ideas for additional tests:
- Test substrings with length longer than 1.
- Test negative start/end (these appear to work).
- Test start/end that overflows (these appear to not raise an exception).
- Test unicode strings (e.g. character code larger than 127, character code larger than 255).
|
for more information, see https://pre-commit.ci
|
All requested tests have been added, this PR is now ready for review. |
JukkaL
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new mypyc primitives for all variations of
str.countfixes 1096