PEP 508: Grammar fixes #851
Conversation
Running the test without the fix results in:
```
>python p508.py
Traceback (most recent call last):
File "p508.py", line 163, in <module>
parsed = compiled(test).specification()
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\parsley.py", line 85, in invokeRule
ret, err = self._grammar.apply(name, *args)
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 462, in apply
val, err = self._apply(r, ruleName, args)
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
[rule(), self.input])
File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1079, in rule_specification
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 598, in _or
ret, err = f()
File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1071, in _G_or_376
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
[rule(), self.input])
File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1006, in rule_url_req
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
[rule(), self.input])
File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 859, in rule_name
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
[rule(), self.input])
File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 850, in rule_identifier
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 676, in consumedby
_, e = expr()
File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 847, in _G_consumedby_294
File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 554, in many
v, _ = fn()
File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 844, in _G_many_296
AttributeError: 'Grammar' object has no attribute 'rule_identifier_end'
```
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Taken from https://www.python.org/dev/peps/pep-0508/ with fixes from python/peps#851 applied
|
Is there any precedent/plan for automated testing of "PEP code"? Should there be? I've taken the liberty of throwing together https://github.com/doismellburning/pep508 because I kept picking up slightly buggy grammar variants but I can't imagine this is the first time something subtle has slipped through... |
|
(I've signed the CLA, just waiting for it to be received and processed) |
|
@mindw Would you be able and willing to sign the CLA please? |
| | marker_and:m -> m | ||
| marker = marker_or | ||
| quoted_marker = ';' wsp* marker | ||
| identifier_end = letterOrDigit | (('-' | '_' | '.' )* letterOrDigit) |
There was a problem hiding this comment.
Could you make this fix without changing spacing in all lines? (for a better history, annotate, etc)
There was a problem hiding this comment.
I'm no fan of vertical alignment for similar reasons, but I was aiming to remain consistent with the author's style
I feel like if I were to PR a fix just to this line, that would be the worst-of-both-worlds - everything vertically aligned apart from one line - and that either this PR (retain alignment) or a two-commit approach (the first to eliminate alignment, the second to fix the bug) are both better options - which would you prefer?
There was a problem hiding this comment.
Doing a second commit has the same issues (misleading history etc).
It also wouldn’t work on Python repos as PRs use squash and merge.
|
Thanks for the PR, but the CLA has still not been signed and this PR now conflicts with the repo, so I'm closing this. |
Taken from pypa/interoperability-peps#66 and
#443