Add the rest of string.Template's class attributes

[kbrose]

Adds the following attributes to string.Template.

$ stubtest --custom-typeshed-dir . string --concise
string.Template.braceidpattern is not present in stub
string.Template.delimiter is not present in stub
string.Template.flags is not present in stub
string.Template.idpattern is not present in stub
string.Template.pattern is not present in stub

Also just wanted to say thanks for the fantastic Good ways to contribute issue.

[kbrose]

I'm not sure what the cause is, but any importing of the re package breaks the stubtest for the Markdown package.

[hauntsaninja]

That's extremely weird. It does appear to be a genuine mistake in the markdown stubs, but I do not see why this change is at all related. @JelleZijlstra any idea what's going on?

[hauntsaninja]

Maybe #6115 will help :-)

[srittau]

That's hopefully fixed now if you merge in master. Also, Pattern should be imported from re, not typing.

[kbrose]

Done

[kbrose]

Appreciate the help, I've rebased from master and took the opportunity to clean up the commits. I'll admit I still don't understand how import re here affects the Markdown package, even after looking at the MR that fixes it.

[kbrose]

I also can't explain the above below diff in poetry.

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

poetry (https://github.com/python-poetry/poetry.git)
- poetry/plugins/plugin_manager.py:22: error: Need type annotation for "_plugins" (hint: "_plugins: List[<type>] = ...")
+ poetry/mixology/failure.py:144: error: Item "RootCause" of "Union[RootCause, NoVersionsCause, DependencyCause, ConflictCause, PythonCause, PlatformCause, PackageNotFoundCause]" has no attribute "conflict"

[srittau]

I just noticed that Pattern is not re-exported from re in Python 3.6. My mistake.

[srittau]

The primer report hints at a real problem with poetry.

[hauntsaninja]

Awesome, thanks for your contribution and for working through the several (some mysterious) issues!

[kbrose]

I wouldn't say I "worked through them", but rather "did nothing and had others fix the problem for me" :)

Once again appreciate the reviews and help on this. Cheers.