Skip to content

Broader patch for ptxas options #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Broader patch for ptxas options #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2295587
broader patch for ptxas options
ptorru May 21, 2025
9e46ec2
Fix: split already returns a list
ptorru May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/tritonbench/install-triton-main.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ rm -rf "${TRITON_PKG_DIR}"

# install main triton
# Patch triton with evo-enablement
patch -p1 < /workspace/tritonbench/.ci/tritonbench/triton-evo.patch
patch -p1 < /workspace/tritonbench/.ci/tritonbench/triton-ptxas.patch
pip install ninja cmake wheel pybind11; # build-time dependencies
pip install -r python/requirements.txt
pip install -e .
Expand Down
12 changes: 4 additions & 8 deletions .ci/tritonbench/triton-evo.patch → .ci/tritonbench/triton-ptxas.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,10 @@ index 58264f29d..6c0209871 100644
fmad = [] if opt.enable_fp_fusion else ['--fmad=false']
arch = sm_arch_from_capability(capability)
opt_level = ['--opt-level', '0'] if knobs.nvidia.disable_ptxas_opt else []
+ if not knobs.nvidia.disable_ptxas_opt and (ptxas_knobs := os.environ.get("PTXAS_KNOBS", None)):
+ dna_abs_path = os.path.abspath(ptxas_knobs)
+ if not os.path.exists(dna_abs_path):
+ raise FileNotFoundError(f"PTXAS_KNOBS file not found at {dna_abs_path}")
+ if dna_abs_path.endswith(".txt") or dna_abs_path.endswith(".json"):
+ opt_level = ["--plain-text-controls", f"--apply-controls={dna_abs_path}"]
+ else:
+ opt_level = [f"--apply-controls={dna_abs_path}"]
+ if not knobs.nvidia.disable_ptxas_opt and (ptxas_options := os.environ.get("PTXAS_OPTIONS", None)):
+ kernel_name = os.environ.get("PTXAS_OPTIONS_KERNEL", None)
+ if not kernel_name or kernel_name == metadata["name"]:
+ opt_level = ptxas_options.split(" ")
ptxas_cmd = [ptxas, *line_info, *fmad, '-v', *opt_level, f'--gpu-name={arch}', fsrc.name, '-o', fbin]
try:
subprocess.run(ptxas_cmd, check=True, close_fds=False, stderr=flog)
Loading